rpccalls::get_mempool refactored

src/rpccalls.cpp

@@ -76,26 +76,29 @@ rpccalls::get_mempool(vector<tx_info>& mempool_txs)
     COMMAND_RPC_GET_TRANSACTION_POOL::request  req;
     COMMAND_RPC_GET_TRANSACTION_POOL::response res;
 
-    std::lock_guard<std::mutex> guard(m_daemon_rpc_mutex);
+    bool r;
 
-    if (!connect_to_monero_deamon())
     {
-        cerr << "get_mempool: not connected to deamon" << endl;
+        std::lock_guard<std::mutex> guard(m_daemon_rpc_mutex);
-        return false;
-    }
 
-    bool r = epee::net_utils::invoke_http_json(
+        if (!connect_to_monero_deamon())
-            "/get_transaction_pool",
+        {
-            req, res, m_http_client, timeout_time_ms);
+            cerr << "get_mempool: not connected to deamon" << endl;
+            return false;
+        }
 
-    if (!r)
+        r = epee::net_utils::invoke_http_json(
+                "/get_transaction_pool",
+                req, res, m_http_client, timeout_time_ms);
+    }
+
+    if (!r || res.status != CORE_RPC_STATUS_OK)
     {
         cerr << "Error connecting to Monero deamon at "
              << deamon_url << endl;
         return false;
     }
 
-
     mempool_txs = res.transactions;
 
     // mempool txs are not sorted base on their arival time,
@@ -107,7 +110,6 @@ rpccalls::get_mempool(vector<tx_info>& mempool_txs)
         return t1.receive_time > t2.receive_time;
     });
 
-
     return true;
 }